linux-kernel - Re: [PATCH] w1: Add Maxim/Dallas DS2780 Stand-Alone Fuel Gauge IC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110510152841.68fabad2.akpm@linux-foundation.org>
Date:	Tue, 10 May 2011 15:28:41 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Barnes, Clifton A." <cabarnes@...esign-llc.com>
Cc:	"johnpol@....mipt.ru" <johnpol@....mipt.ru>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>
Subject: Re: [PATCH] w1: Add Maxim/Dallas DS2780 Stand-Alone Fuel Gauge IC
 support.

On Wed, 20 Apr 2011 19:57:05 +0000
"Barnes, Clifton A." <cabarnes@...esign-llc.com> wrote:

> Add support for the Maxim/Dallas DS2780 Stand-Alone Fuel Gauge IC.
> 
> Another patch from Haojian Zhuang for this part was recently submitted,
> but I believe that this implementation is more consistent with other
> fuel gauge drivers since it uses the power supply interface.
> 

hm, you're not a heavy user of scripts/checkpatch.pl, I see:

total: 190 errors, 704 warnings, 1221 lines checked

that must be a record.

>
> ...
>
> +       new_setting = (u8)simple_strtoul(buf, &endp, 10);

This checkpatch warning is more than cosmetic:

WARNING: consider using kstrto* in preference to simple_strtoul

This is because simple_strtoul() will accept input of the form "42foo"
whereas strict_strtoul() (and, more recently, kstrtoul()) will reject
it.  So fixing that sloppiness in the interface would be a userspace
API change, and we don't like those.

Please go through the patch and clean it up a bit?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/