[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BANLkTi=PyObf4pm7xF8jT7hcDgpJVrCdSg@mail.gmail.com>
Date: Wed, 11 May 2011 21:17:25 +0800
From: li jianyun <jianyunff@...il.com>
To: Rolf Eike Beer <eike@...mail.de>
Cc: James.Bottomley@...e.de, Jianyun Li <jyli@...vell.com>,
"open list:SCSI SUBSYSTEM" <linux-scsi@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
"open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH v2] Add Marvell UMI driver
2011/5/10 Rolf Eike Beer <eike@...mail.de>:
>
>
>> +static unsigned char tag_is_empty(struct tag_stack *st)
>> +{
>> + if (st->top == 0)
>> + return 1;
>> + else
>> + return 0;
>> +}
>
> The return value should be bool. But I don't think this function is worth it,
> I can only find one place where it is used at all.
>
it may be easy to understand. so I am not modify it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists