linux-kernel - Re: [PATCH v2] x86: UV BAU fix for non-consecutive nasids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110511072500.GJ22551@elte.hu>
Date:	Wed, 11 May 2011 09:25:00 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cliff Wickman <cpw@....com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v2] x86: UV BAU fix for non-consecutive nasids

* Cliff Wickman <cpw@....com> wrote:

> From: Cliff Wickman <cpw@....com>
> 
> (patch v2 has improved changelog and correction of a broken line)

but i did not point out just a single broken line - there's literally a dozen 
in your patch, still!

*All* of these measures i mentioned in my previous mail:

  - eliminate many repetitive strings
  - reduce indentation by the introduction of helper inlines
  - sensible shortening of variable/field/definition names

... applies to this particular case and will solve the problem.

This whole file is still utterly ugly and i'm not surprised at all it's showing 
bugs. Functions are still *way* too large and the code is hard to read.

If you don't know how to simplify a particular function then please ask but i 
see half a dozen things that could be done to clean up any of these big 
functions, just at a first quick glance. Those patterns of code ugliness repeat 
all over the whole file!

I dont mind if you do it as delta patches after this fix (so that the fix stays 
mergable) but we need to see progress in this code first, the pain in this file 
has been going on for *way* too long.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/