linux-kernel - Re: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110511170307.GD21345@caffeine.csclub.uwaterloo.ca>
Date:	Wed, 11 May 2011 13:03:07 -0400
From:	lsorense@...lub.uwaterloo.ca (Lennart Sorensen)
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
Cc:	linux-kernel@...r.kernel.org,
	Mingkai Hu <Mingkai.hu@...escale.com>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: spi_fsl_spi broken when compiled as module by
 b36ece832512c1a0afa54ff0a56d63492a1caf08

On Wed, May 11, 2011 at 11:52:11AM -0400, Lennart Sorensen wrote:
> When code was refactored, spi_fsl_spi now depends on funfcionts in
> spi-fsl_lib, but those are not exported symbols so when building as a
> module the symbols are missing and the compile fails.
> 
> Adding these to spi_fsl_lib.c fixes the compile.
> 
> EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u32);
> EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u32);
> EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u16);
> EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u16);
> EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u8);
> EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u8);
> EXPORT_SYMBOL(mpc8xxx_spi_strmode);
> EXPORT_SYMBOL(mpc8xxx_spi_probe);
> EXPORT_SYMBOL(of_mpc8xxx_spi_probe);
> EXPORT_SYMBOL(mpc8xxx_spi_remove);
> EXPORT_SYMBOL(to_of_pinfo);
> 
> All releases since the refactoring was done would be affected.

Of course a MODULE_LICENSE("GPL"); helps too.

-- 
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/