linux-kernel - Re: PM / Wakeup: remove useless synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201105112243.47480.rjw@sisk.pl>
Date:	Wed, 11 May 2011 22:43:47 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	David Miller <davem@...emloft.net>
Subject: Re: PM / Wakeup: remove useless synchronize_rcu() call

On Wednesday, May 11, 2011, Eric Dumazet wrote:
> wakeup_source_add() adds an item into wakeup_sources list.
> 
> There is no need to call synchronize_rcu() at this point.
> 
> Its only needed in wakeup_source_remove()
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> CC: David Miller <davem@...emloft.net>,
> CC: Greg Kroah-Hartman <gregkh@...e.de>

Applied to suspend-2.6/linux-next.

Thanks,
Rafael


> ---
>  drivers/base/power/wakeup.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
> index abbbd33..84f7c7d 100644
> --- a/drivers/base/power/wakeup.c
> +++ b/drivers/base/power/wakeup.c
> @@ -110,7 +110,6 @@ void wakeup_source_add(struct wakeup_source *ws)
>  	spin_lock_irq(&events_lock);
>  	list_add_rcu(&ws->entry, &wakeup_sources);
>  	spin_unlock_irq(&events_lock);
> -	synchronize_rcu();
>  }
>  EXPORT_SYMBOL_GPL(wakeup_source_add);
>  
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/