| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <BANLkTikg-oZrevgm-g+M=FO+O-uj5OyaEQ@mail.gmail.com> Date: Wed, 11 May 2011 15:56:04 -0700 From: matt mooney <mfmooney@...il.com> To: Greg KH <greg@...ah.com> Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 06/12] staging: usbip: stub_main.c: code cleanup On Wed, May 11, 2011 at 2:08 PM, Greg KH <greg@...ah.com> wrote: > On Wed, May 11, 2011 at 01:54:18AM -0700, matt mooney wrote: >> Reorder functions; remove match_find() and replace with >> get_busid_idx(); change other functions to use get_busid_idx(); and >> code cleanup in the other functions. >> >> Signed-off-by: matt mooney <mfm@...eddisk.com> >> --- >> I apologize for this one. I realize that I should have split it into two with >> the reorder being separate. > > Yes, please split it up. Okay, I have to try and figure out a sane way of doing this but I will split it. >> Also, it seems as if there is a synchronization problem carried over from the >> original code in get_busid_priv(). An address into the busid_table is returned >> and then the element is accessed and modified elsewhere. Right? Or am I missing >> something. > > You might be correct, I don't really know. > Yeah I will have to figure that out as I go. -- GPG-Key: 9AFE00EA -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists