linux-kernel - Re: [RFC PATCH] perf: Carve out cgroup-related code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110512110321.GO9937@elte.hu>
Date:	Thu, 12 May 2011 13:03:21 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Borislav Petkov <bp@...64.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] perf: Carve out cgroup-related code


* Borislav Petkov <bp@...64.org> wrote:

> On Thu, May 12, 2011 at 06:36:44AM -0400, Ingo Molnar wrote:
> > 
> > * Borislav Petkov <bp@...64.org> wrote:
> > 
> > > Done, patch below. I've moved all exports local to kernel/events/* to
> > > internal.h. Branch at
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git perf-split
> > 
> > Beyond the things Peter noticed, there's also this new bit in perf_event.h:
> > 
> > enum event_type_t {
> >         EVENT_FLEXIBLE = 0x1,
> >         EVENT_PINNED = 0x2,
> >         EVENT_ALL = EVENT_FLEXIBLE | EVENT_PINNED,
> > };
> > 
> > this got there from core.c, albeit it's only core.c that uses it.
> > 
> > If then this should move to internal.h - or stay local to core.c.
> 
> event_type_t gets pulled by pushing
> 
> ctx_sched_out(..., enum event_type_t event_type)
> 
> up into the header since otherwise gcc complains of not seeing the
> definition of the third argument.
> 
> And yes, it should go to internal.h.

yeah.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/