linux-kernel - RE: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1105121040190.1917-100000@iolanthe.rowland.org>
Date:	Thu, 12 May 2011 10:45:43 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Tanya Brokhman <tlinder@...eaurora.org>
cc:	'Sebastian Andrzej Siewior' <bigeasy@...utronix.de>,
	<greg@...ah.com>, <linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <balbi@...com>,
	<ablay@...eaurora.org>, 'open list' <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy_hcd

On Thu, 12 May 2011, Tanya Brokhman wrote:

> > >+	retval = usb_add_hcd(hs_hcd, 0, IRQF_DISABLED | IRQF_SHARED);
> > Why IRQF_DISABLED | IRQF_SHARED? you don't interrupts at all.
> 
> I used xhci as reference for this patch. This is the way xhci driver adds
> the hcds. You can find it in xhci_pci_probe(). 
> I'm not very familiar with how this two hcds (main and shared shcd) will
> work together so I thought these flags are needed for their co-operation. 
> Was my assumption mistaken? What flags should I use? 

You don't need any flags at all, because dummy-hcd does not handle any 
hardware interrupts.

> Also, Sergei pointed out that IRQF_DISABLED is deprecated so it seems to me
> that xhci needs an update as well....

Plus every other source file that uses IRQF_DISABLED...

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/