linux-kernel - Re: [PATCH 2/2] Staging: comedi: fix tabulation and over 80 chars issues in amplc_pci224.c This is a patch to the amplc_pci224.c file that fixes up tabulation style errors and over 80 chars warning found by the checkpatch.pl tool Signed-off-by: Steph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110512204009.GA3735@suse.de>
Date:	Thu, 12 May 2011 13:40:09 -0700
From:	Greg KH <gregkh@...e.de>
To:	Stéphane Pajot <pajot.stephane@...il.com>
Cc:	arun.thomas@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: fix tabulation and over 80 chars
 issues in amplc_pci224.c This is a patch to the amplc_pci224.c file that
 fixes up tabulation style errors and over 80 chars warning found by the
 checkpatch.pl tool Signed-off-by: Steph

On Thu, May 12, 2011 at 10:03:35PM +0200, Stéphane Pajot wrote:
> My answer in purple :

Purple doesn't show up in plain text email clients :(

> 2011/5/12 Greg KH <gregkh@...e.de>
> 
>     On Thu, May 12, 2011 at 06:44:58PM +0200, Stephane Pajot wrote:
>     > ---
>     >  drivers/staging/comedi/drivers/amplc_pci224.c |   63
>     +++++++++++++------------
>     >  1 files changed, 33 insertions(+), 30 deletions(-)
>     >
>     > diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/
>     staging/comedi/drivers/amplc_pci224.c
>     > index 1b5ba1c..2f61358 100644
>     > --- a/drivers/staging/comedi/drivers/amplc_pci224.c
>     > +++ b/drivers/staging/comedi/drivers/amplc_pci224.c
>     > @@ -52,33 +52,33 @@ Supports:
>     >  Configuration options - PCI224:
>     >    [0] - PCI bus of device (optional).
>     >    [1] - PCI slot of device (optional).
>     > -          If bus/slot is not specified, the first available PCI device
>     > -          will be used.
>     > +     If bus/slot is not specified, the first available PCI device
>     > +     will be used.
> 
>     Why did you change these comment lines ? 
> 
> 
> I change the space by a tabulation. Checkpatch.pl return errors about that
> (maybe it's a mistake...). Question : when checkpatch.pl return this kind of
> error (tabulation, or style in general) do we have to correct it too ?    

Just leave it alone, checkpatch isn't always correct, it's a guideline.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/