linux-kernel - Re: [PATCH 3/3] comm: ext4: Protect task->comm access by using %ptc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1305239380.2680.26.camel@work-vm>
Date:	Thu, 12 May 2011 15:29:40 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, "Ted Ts'o" <tytso@....edu>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH 3/3] comm: ext4: Protect task->comm access by using %ptc

On Thu, 2011-05-12 at 15:14 -0700, David Rientjes wrote:
> On Tue, 10 May 2011, John Stultz wrote:
> 
> > Converts ext4 comm access to use the safe printk %ptc accessor.
> > 
> > CC: Ted Ts'o <tytso@....edu>
> > CC: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> > CC: David Rientjes <rientjes@...gle.com>
> > CC: Dave Hansen <dave@...ux.vnet.ibm.com>
> > CC: Andrew Morton <akpm@...ux-foundation.org>
> > CC: linux-mm@...ck.org
> > Signed-off-by: John Stultz <john.stultz@...aro.org>
> 
> I like how this patch illustrates how easy it is to use the new method for 
> printing a task's command, but it would probably be easier to get the 
> first two patches in the series (those that add the seqlock and then %ptc) 
> merged in mainline and then break out a series of conversions such as this 
> that could go through the individual maintainer's trees.

Agreed. I just wanted to show how it would be used compared to the
earlier approach.

I'll respin the first two patches shortly here. I also need to get the
checkpatch bit done.

Andrew, should these go upstream through you?

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/