linux-kernel - Re: [PATCH 7/8] powerpc: use the newly added get_required_mask dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2011 07:51:32 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Nishanth Aravamudan <nacc@...ibm.com>,
	Milton Miller <miltonm@....com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Arnd Bergmann <arnd@...db.de>,
	Geoff Levand <geoff@...radead.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Andrew Morton <akpm@...ux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	"H. Peter Anvin" <hpa@...or.com>,
	"David S. Miller" <davem@...emloft.net>,
	Sean MacLennan <smaclennan@...atech.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Will Schmidt <will_schmidt@...t.ibm.com>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	cbe-oss-dev@...ts.ozlabs.org
Subject: Re: [PATCH 7/8] powerpc: use the newly added get_required_mask
 dma_map_ops hook

On Thu, May 12, 2011 at 00:25, Nishanth Aravamudan <nacc@...ibm.com> wrote:
> diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c
> index 23083c3..688141c 100644
> --- a/arch/powerpc/platforms/ps3/system-bus.c
> +++ b/arch/powerpc/platforms/ps3/system-bus.c
> @@ -695,12 +695,18 @@ static int ps3_dma_supported(struct device *_dev, u64 mask)
>        return mask >= DMA_BIT_MASK(32);
>  }
>
> +static u64 ps3_dma_get_required_mask(struct device *_dev)
> +{
> +       return DMA_BIT_MASK(32);

Why 32 and not 64?

> +}
> +
>  static struct dma_map_ops ps3_sb_dma_ops = {
>        .alloc_coherent = ps3_alloc_coherent,
>        .free_coherent = ps3_free_coherent,
>        .map_sg = ps3_sb_map_sg,
>        .unmap_sg = ps3_sb_unmap_sg,
>        .dma_supported = ps3_dma_supported,
> +       .get_required_mask = ps3_dma_get_required_mask,
>        .map_page = ps3_sb_map_page,
>        .unmap_page = ps3_unmap_page,
>  };
> @@ -711,6 +717,7 @@ static struct dma_map_ops ps3_ioc0_dma_ops = {
>        .map_sg = ps3_ioc0_map_sg,
>        .unmap_sg = ps3_ioc0_unmap_sg,
>        .dma_supported = ps3_dma_supported,
> +       .get_required_mask = ps3_dma_get_required_mask,
>        .map_page = ps3_ioc0_map_page,
>        .unmap_page = ps3_unmap_page,
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/