[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1305290092.3202.6.camel@odin>
Date: Fri, 13 May 2011 13:34:52 +0100
From: Liam Girdwood <lrg@...mlogic.co.uk>
To: Axel Lin <axel.lin@...il.com>
Cc: linux-kernel@...r.kernel.org, Anuj Aggarwal <anuj.aggarwal@...com>,
Graeme Gregory <gg@...mlogic.co.uk>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: Fix desc_id for tps65023/6507x/65910
On Thu, 2011-05-12 at 13:47 +0800, Axel Lin wrote:
> The desc_id variable should not be a static variable.
>
> The rest of the code assumes the desc_id must less than TPSxxxxx_NUM_REGULATOR.
> If we set desc_id to be a static variable, checking the return value of
> rdev_get_id() may return error.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> Cc: Anuj Aggarwal <anuj.aggarwal@...com>
> Cc: Graeme Gregory <gg@...mlogic.co.uk>
Applied.
Liam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists