linux-kernel - Re: [PATCHv2 4/5] TPS65911: Add support for added GPIO lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110513163304.GJ8970@sortiz-mobl>
Date:	Fri, 13 May 2011 18:33:05 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
Cc:	linux-kernel@...r.kernel.org, broonie@...nsource.wolfsonmicro.com,
	lrg@...com, Graeme Gregory <gg@...mlogic.co.uk>,
	grant.likely@...retlab.ca
Subject: Re: [PATCHv2 4/5] TPS65911: Add support for added GPIO lines

Hi Jorge,

On Wed, May 04, 2011 at 07:21:41PM -0500, Jorge Eduardo Candelaria wrote:
> @@ -76,7 +77,12 @@ void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base)
>  	tps65910->gpio.label		= tps65910->i2c_client->name;
>  	tps65910->gpio.dev		= tps65910->dev;
>  	tps65910->gpio.base		= gpio_base;
> -	tps65910->gpio.ngpio		= 1;
> +	if (tps65910_chip_id(tps65910) == TPS65910)
> +		tps65910->gpio.ngpio		= 6;
> +	else if (tps65910_chip_id(tps65910) == TPS65911)
> +		tps65910->gpio.ngpio		= 9;
> +	else
> +		return;
That should be handled through a switch statement too.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/