linux-kernel - Re: [PATCH-v3 13/14] iscsi-target: Add misc utility and debug logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikMdAUjT=G+DHaJwDOXuh532uN8nw@mail.gmail.com>
Date:	Fri, 13 May 2011 21:30:41 +0200
From:	Arne Redlich <arne.redlich@...glemail.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Christoph Hellwig <hch@....de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Hannes Reinecke <hare@...e.de>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Andy Grover <agrover@...hat.com>,
	Mike Christie <michaelc@...wisc.edu>,
	Boaz Harrosh <bharrosh@...asas.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Martin Svec <martin.svec@...er.cz>
Subject: Re: [PATCH-v3 13/14] iscsi-target: Add misc utility and debug logic

2011/5/12 Nicholas A. Bellinger <nab@...ux-iscsi.org>:
> From: Nicholas Bellinger <nab@...ux-iscsi.org>
>
> This file adds iscsi_target_util.[c,h] code containing a number
> of miscellaneous utility functions for iscsi_target_mod.
>
> It also contains iscsi_debug.h macros for CONFIG_ISCSI_TARGET_DEBUG
>
> Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org>

<snip>

> diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c
> new file mode 100644
> index 0000000..af1c5c44
> --- /dev/null
> +++ b/drivers/target/iscsi/iscsi_target_util.c

<snip>

> +
> +struct iscsi_r2t *iscsit_get_r2t_for_eos(
> +       struct iscsi_cmd *cmd,
> +       u32 offset,
> +       u32 length)
> +{
> +       struct iscsi_r2t *r2t;
> +
> +       spin_lock_bh(&cmd->r2t_lock);
> +       list_for_each_entry(r2t, &cmd->cmd_r2t_list, r2t_list) {
> +               if ((r2t->offset <= offset) &&
> +                   (r2t->offset + r2t->xfer_len) >= (offset + length))
> +                       break;
> +       }
> +       spin_unlock_bh(&cmd->r2t_lock);
> +
> +       if (!r2t) {
> +               printk(KERN_ERR "Unable to locate R2T for Offset: %u, Length:"
> +                               " %u\n", offset, length);
> +               return NULL;
> +       }
> +
> +       return r2t;
> +}
> +

Nicholas,

This lookup pattern (repeated several times throughout the patch)
looks seriously flawed to me as r2t will never be NULL.

Arne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/