| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1305270943.3487.5.camel@jlt3.sipsolutions.net> Date: Fri, 13 May 2011 09:15:43 +0200 From: Johannes Berg <johannes@...solutions.net> To: Rhyland Klein <rklein@...dia.com> Cc: "olof@...om.net" <olof@...om.net>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] net: rfkill: add generic gpio rfkill driver On Thu, 2011-05-12 at 14:23 -0700, Rhyland Klein wrote: > On Thu, 2011-05-12 at 12:02 -0700, Johannes Berg wrote: > > On Thu, 2011-05-12 at 11:52 -0700, Rhyland Klein wrote: > > > > > > If, on the other hand, rfkill decides that at the time of loading the > > > > driver wifi should be on, then the first change would be +1 and it'll > > > > flip between 0 and +1. > > > > > > > > This seems like it'll cause issues at some point, so I think you should > > > > either allow the driver to set the initial state or hardcode one of > > > > these possibilities (so at least it's predictable) > > > > > I won't go negative, if you look, it only will disable clock if it knows > > > it has already enabled it. > > > > Ah, you're right, I misread the macros. > So the patch is good as is? I think so, yes. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists