linux-kernel - Re: [RFC PATCH] input: Add wiichuck driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTi=4oCehWLXrKbd6bj2CuoxDXdBHAg@mail.gmail.com>
Date:	Sat, 14 May 2011 21:20:04 +0200
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [RFC PATCH] input: Add wiichuck driver

On Sat, May 14, 2011 at 9:17 PM, Oliver Neukum <oliver@...kum.org> wrote:
> Am Donnerstag, 12. Mai 2011, 06:29:44 schrieb Grant Likely:
>> +static void wiichuck_poll(struct input_polled_dev *poll_dev)
>> +{
>> +       struct wiichuck_device *wiichuck = poll_dev->private;
>> +       struct i2c_client *i2c = wiichuck->i2c_client;
>> +       static uint8_t cmd_byte = 0;
>> +       struct i2c_msg cmd_msg =
>> +               { .addr = i2c->addr, .len = 1, .buf = &cmd_byte };
>> +       uint8_t b[6];
>> +       struct i2c_msg data_msg =
>> +               { .addr = i2c->addr, .flags = I2C_M_RD, .len = 6, .buf = b };
>
>
> Do you need these buffers to be capable of DMA?

Good point.  Yes, these buffers should be DMA capable.  I'll pull them
off the stack.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/