linux-kernel - Re: [PATCH v1] mfd: Fix omap_usbhs_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110516122926.GE11339@legolas.emea.dhcp.ti.com>
Date:	Mon, 16 May 2011 15:29:27 +0300
From:	Felipe Balbi <balbi@...com>
To:	Keshava Munegowda <keshava_mgowda@...com>
Cc:	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, balbi@...com, gadiyar@...com,
	sameo@...ux.intel.com, parthab@...ia.ti.com, axel.lin@...il.com
Subject: Re: [PATCH v1] mfd: Fix omap_usbhs_alloc_children error handling

On Mon, May 16, 2011 at 05:54:07PM +0530, Keshava Munegowda wrote:
> From: Axel Lin <axel.lin@...il.com>
> 
> rebased on top of hwmod and runtime pm patch series of usbhs
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> Tested-by: Keshava Munegowda <keshava_mgowda@...com>

Acked-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/mfd/omap-usb-host.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index e1bc3b5..32d19e2 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -282,6 +282,7 @@ static int omap_usbhs_alloc_children(struct platform_device *pdev)
>  
>  	if (!ehci) {
>  		dev_err(dev, "omap_usbhs_alloc_child failed\n");
> +		ret = -ENOMEM;
>  		goto err_end;
>  	}
>  
> @@ -305,13 +306,14 @@ static int omap_usbhs_alloc_children(struct platform_device *pdev)
>  		sizeof(*ohci_data), dev);
>  	if (!ohci) {
>  		dev_err(dev, "omap_usbhs_alloc_child failed\n");
> +		ret = -ENOMEM;
>  		goto err_ehci;
>  	}
>  
>  	return 0;
>  
>  err_ehci:
> -	platform_device_put(ehci);
> +	platform_device_unregister(ehci);
>  
>  err_end:
>  	return ret;
> -- 
> 1.6.0.4
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)