linux-kernel - Re: [PATCH] kbuild: make KBUILD_NOCMDDEP=1 handle empty built-in.o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110516144413.GN13293@sepie.suse.cz>
Date:	Mon, 16 May 2011 16:44:13 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Rabin Vincent <rabin@....in>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] kbuild: make KBUILD_NOCMDDEP=1 handle empty built-in.o

On Sun, May 15, 2011 at 11:07:19PM +0530, Rabin Vincent wrote:
> On Thu, May 12, 2011 at 19:03, Michal Marek <mmarek@...e.cz> wrote:
> > I'm not sure if this is the rigt way to fix it. Kbuild.include should
> > not care about obj-*. The problem is that arg-check is always empty with
> > KBUILD_NOCMDDEP and if there are no other dependencies, the target will
> > not be created, right? IMO we only need to make sure that during the
> > first make run, arg-check always expands to non-empty, even with
> > KBUILD_NOCMDDEP. So we can drop the $(obj-y) test and do it like this
> > (untested), can't we?
> >
> > diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> > index c034dd7..be39cd1 100644
> > --- a/scripts/Kbuild.include
> > +++ b/scripts/Kbuild.include
> > @@ -197,6 +197,8 @@ ifneq ($(KBUILD_NOCMDDEP),1)
> >  # User may override this check using make KBUILD_NOCMDDEP=1
> >  arg-check = $(strip $(filter-out $(cmd_$(1)), $(cmd_$@)) \
> >                     $(filter-out $(cmd_$@),   $(cmd_$(1))) )
> > +else
> > +arg-check = $(if $(strip $(cmd_$@)),,1)
> >  endif
> >
> >  # >'< substitution is for echo to work,
> 
> This works for me, thanks.
> 
> Tested-by: Rabin Vincent <rabin@....in>

Thanks, pushed to kbuild-2.6.git#kbuild.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/