linux-kernel - wireless-next-2.6 rebased -- Re: [PATCH v2] net: rfkill: add generic gpio rfkill driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110516181348.GD6551@tuxdriver.com>
Date:	Mon, 16 May 2011 14:13:49 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Rhyland Klein <rklein@...dia.com>
Cc:	"olof@...om.net" <olof@...om.net>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Johannes Berg <johannes@...solutions.net>
Subject: wireless-next-2.6 rebased -- Re: [PATCH v2] net: rfkill: add generic
 gpio rfkill driver

FYI, I'm rebasing wireless-next to avoid pushing this bad commit to
net-next-2.6.  If you pulled wireless-next-2.6.git over the weekend,
you may experience some rebase-related problems.

John

On Fri, May 13, 2011 at 04:11:31PM -0400, John W. Linville wrote:
> On Fri, May 13, 2011 at 03:20:20PM -0400, John W. Linville wrote:
> > On Fri, May 13, 2011 at 12:02:54PM -0700, Rhyland Klein wrote:
> > > On Fri, 2011-05-13 at 00:15 -0700, Johannes Berg wrote:
> > > > On Thu, 2011-05-12 at 14:23 -0700, Rhyland Klein wrote:
> > > > > On Thu, 2011-05-12 at 12:02 -0700, Johannes Berg wrote:
> > > > > > On Thu, 2011-05-12 at 11:52 -0700, Rhyland Klein wrote:
> > > > > > 
> > > > > > > > If, on the other hand, rfkill decides that at the time of loading the
> > > > > > > > driver wifi should be on, then the first change would be +1 and it'll
> > > > > > > > flip between 0 and +1.
> > > > > > > > 
> > > > > > > > This seems like it'll cause issues at some point, so I think you should
> > > > > > > > either allow the driver to set the initial state or hardcode one of
> > > > > > > > these possibilities (so at least it's predictable)
> > > > > > 
> > > > > > > I won't go negative, if you look, it only will disable clock if it knows
> > > > > > > it has already enabled it. 
> > > > > > 
> > > > > > Ah, you're right, I misread the macros.
> > > > 
> > > > > So the patch is good as is?
> > > > 
> > > > I think so, yes.
> > > > 
> > > > johannes
> > > > 
> > > 
> > > John, Johannes suggested you are able to pull in this patch?
> > 
> > I've got it, thanks.
> 
>   Building modules, stage 2.
>   MODPOST 2346 modules
> ERROR: "clk_get" [net/rfkill/rfkill-gpio.ko] undefined!
> ERROR: "clk_enable" [net/rfkill/rfkill-gpio.ko] undefined!
> ERROR: "clk_put" [net/rfkill/rfkill-gpio.ko] undefined!
> ERROR: "clk_disable" [net/rfkill/rfkill-gpio.ko] undefined!
> WARNING: modpost: Found 5 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> Is there something we should add to Kconfig to prevent this?
> 
> John
> -- 
> John W. Linville		Someday the world will need a hero, and you
> linville@...driver.com			might be all we have.  Be ready.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/