linux-kernel - Re: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTimJgZmghcTTtR8ZmU5mWfwG=iSv7g@mail.gmail.com>
Date:	Mon, 16 May 2011 14:01:54 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
Cc:	Hu Mingkai-B21284 <B21284@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kumar Gala <galak@...nel.crashing.org>
Subject: Re: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08

On Mon, May 16, 2011 at 1:52 PM, Lennart Sorensen
<lsorense@...lub.uwaterloo.ca> wrote:
>> >  struct mpc8xxx_spi_probe_info *to_of_pinfo(struct fsl_spi_platform_data *pdata)
>> >  {
>> >        return container_of(pdata, struct mpc8xxx_spi_probe_info, pdata);
>> >  }
>> > +EXPORT_SYMBOL(to_of_pinfo);
>>
>> Hmmm,. this is not so good because it exports rather generically named
>> functions out to the global namespace.  These functions should be
>> renamed to have an mpc8xxx_spi_ prefix before exporting.
>>
>> Otherwise this patch looks good.
>
> Hmm, yeah it did look like a crappy function name, but I just wanted to
> fix the problem, not try to guess what the author of the code intended.
> Prefixing it makes sense.

Alternately, you can move that function to the common header as a
static inline.  It's just a container_of() wrapper after all, so
moving it would probably be better.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/