linux-kernel - Re: [PATCH RESEND] mfd: Fix off-by-one value range checking for tps65910_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 May 2011 21:19:10 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Graeme Gregory <gg@...mlogic.co.uk>,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH RESEND] mfd: Fix off-by-one value range checking for
 tps65910_i2c_write

On Mon, 2011-05-16 at 22:19 +0800, Axel Lin wrote:
> If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
> doing memcpy(&msg[1], src, bytes).
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> Acked-by: Samuel Ortiz <sameo@...ux.intel.com>
> ---
>  drivers/mfd/tps65910.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index bf649cf..e318248 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
>  	u8 msg[TPS65910_MAX_REGISTER + 1];
>  	int ret;
>  
> -	if (bytes > (TPS65910_MAX_REGISTER + 1))
> +	if (bytes > TPS65910_MAX_REGISTER)
>  		return -EINVAL;
>  
>  	msg[0] = reg;

Applied.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/