linux-kernel - Re: [PATCH] module: Use binary search in lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1305580103.2503.21.camel@Joe-Laptop>
Date:	Mon, 16 May 2011 14:08:23 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alessio Igor Bogani <abogani@...nel.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Anders Kaseorg <andersk@...lice.com>,
	Tim Abbott <tabbott@...lice.com>,
	Tim Bird <tim.bird@...sony.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Embedded <linux-embedded@...r.kernel.org>,
	Jason Wessel <jason.wessel@...driver.com>,
	Dirk Behme <dirk.behme@...glemail.com>
Subject: Re: [PATCH] module: Use binary search in lookup_symbol()

On Mon, 2011-05-16 at 14:01 -0700, Joe Perches wrote:
> On Mon, 2011-05-16 at 22:23 +0200, Alessio Igor Bogani wrote:
> > Signed-off-by: Alessio Igor Bogani <abogani@...nel.org>
> > diff --git a/kernel/module.c b/kernel/module.c
> > @@ -2055,10 +2055,8 @@ static const struct kernel_symbol *lookup_symbol(const char *name,
> >  	const struct kernel_symbol *stop)
> >  {
> >  	const struct kernel_symbol *ks = start;
> > -	for (; ks < stop; ks++)
> > -		if (strcmp(ks->name, name) == 0)
> > -			return ks;
> > -	return NULL;
> > +	return bsearch(name, start, stop - start,
> > +			sizeof(struct kernel_symbol), cmp_name);
[]
> why cmp_name and not strcmp?

Nevermind, cmp_name is obviously correct.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/