linux-kernel - Re: [PATCH] input: Add Nintendo extension controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikfNZtP8DXH99RJE8H4pgZm4b9mjg@mail.gmail.com>
Date:	Mon, 16 May 2011 17:04:04 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Ben Dooks <ben@...nity.fluff.org>, simon@...gewell.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	OliverNeukumoliver@...kum.org
Subject: Re: [PATCH] input: Add Nintendo extension controller driver

On Mon, May 16, 2011 at 4:43 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Mon, May 16, 2011 at 10:51:10PM +0100, Ben Dooks wrote:
>> On Mon, May 16, 2011 at 03:46:08PM -0600, Grant Likely wrote:
>> > +
>> > +   /*
>> > +    * DMA buffer, with padding to give it its own cache line so that
>> > +    * the DMA streaming works on non-coherent architectures.
>> > +    * Question: Is this the proper pattern, and is this really necessary?
>> > +    */
>> > +   uint8_t pad1[L1_CACHE_BYTES];
>> > +   uint8_t buf[6];
>> > +   uint8_t pad2[L1_CACHE_BYTES];
>> > +};
>>
>> I think there's an attribute to do this, starting with an __ defined
>> in the kernel.
>>
>
> Yes, it is called "____cacheline_aligned".

Fixed and tested, thanks.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/