linux-kernel - Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.vvlj1vad3l0zgt@mnazarewicz-glaptop>
Date:	Tue, 17 May 2011 01:11:45 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"David Rientjes" <rientjes@...gle.com>,
	"Andy Whitcroft" <apw@...onical.com>,
	"Joe Perches" <joe@...ches.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"John Stultz" <john.stultz@...aro.org>, "Ted Ts'o" <tytso@....edu>,
	"Jiri Slaby" <jirislaby@...il.com>,
	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>,
	"Dave Hansen" <dave@...ux.vnet.ibm.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references

On Tue, 17 May 2011 01:04:50 +0200, Joe Perches <joe@...ches.com> wrote:

> On Mon, 2011-05-16 at 14:34 -0700, David Rientjes wrote:
>> On Mon, 16 May 2011, Michal Nazarewicz wrote:
>> > > Now that accessing current->comm needs to be protected,
>> > > +# check for current->comm usage
>> > > +		if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
>> > Not a checkpatch.pl expert but as far as I'm concerned, that looks  
>> reasonable.
>
> I think the only checkpatch expert is Andy Whitcroft.
>
> You don't need (?: just (

Yep, it's a micro-optimisation though.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/