linux-kernel - Re: [PATCH 0/2] AMD ARAT fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110517165318.GH30053@aftab>
Date:	Tue, 17 May 2011 18:53:18 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Jörg-Volker Peetz <jvpeetz@....de>
Cc:	Borislav Petkov <bp@...64.org>,
	Nick Bowler <nbowler@...iptictech.com>,
	"Ostrovsky, Boris" <Boris.Ostrovsky@....com>,
	"Herrmann3, Andreas" <Andreas.Herrmann3@....com>,
	Greg Kroah-Hartman <greg@...ah.com>,
	"Rosenfeld, Hans" <Hans.Rosenfeld@....com>,
	X86-ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] AMD ARAT fixes

On Tue, May 17, 2011 at 12:38:46PM -0400, Jörg-Volker Peetz wrote:
> A kernel version 2.6.38.6 patched with your two patches modifying only
> arch/x86/kernel/cpu/amd.c starts and runs without problems on the affected
> system with a AMD Turion 64 processor. The system is pure x86_64 (Debian
> Release: wheezy/sid) with gcc version 4.6.1 20110428 (prerelease) (Debian
> 4.6.0-6) and GNU C Library (Debian EGLIBC 2.13-4) stable release version 2.13.

Thanks for testing!

> The only obvious difference I see is the message "using C1E aware idle routine"
> in dmesg.

That was your CPU, right:

vendor_id       : AuthenticAMD
cpu family      : 15
model           : 36
model name      : AMD Turion(tm) 64 Mobile Technology MT-40
stepping        : 2

?

If so, then the C1E idle line above shouldn't appear. Can you check that
around line 698 in <arch/x86/kernel/cpu/amd.c> you have the following:

 const int amd_erratum_400[] =
       AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0xf, 0x41, 0x2, 0xff, 0xf),
                           AMD_MODEL_RANGE(0x10, 0x2, 0x1, 0xff, 0xf));

On your machine, you should be using the default_idle routine instead,
since you don't have C1E.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/