linux-kernel - Re: [PATCH V7] bcma: add Broadcom specific AMBA bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTin7woaT5Uaxvh4x2jp-J10jnzSdmA@mail.gmail.com>
Date:	Tue, 17 May 2011 19:48:18 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Arend van Spriel <arend@...adcom.com>
Cc:	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"John W. Linville" <linville@...driver.com>,
	"b43-dev@...ts.infradead.org" <b43-dev@...ts.infradead.org>,
	Greg KH <greg@...ah.com>,
	Michael Büsch <mb@...sch.de>,
	Larry Finger <Larry.Finger@...inger.net>,
	George Kashperko <george@...u.edu.ua>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <rmk@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Andy Botting <andy@...ybotting.com>,
	linuxdriverproject <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V7] bcma: add Broadcom specific AMBA bus driver

2011/5/17 Arend van Spriel <arend@...adcom.com>:
> On 05/09/2011 06:56 PM, Rafał Miłecki wrote:
>>
>> Broadcom has released cards based on a new AMBA-based bus type. From a
>> programming point of view, this new bus type differs from AMBA and does
>> not use AMBA common registers. It also differs enough from SSB. We
>> decided that a new bus driver is needed to keep the code clean.
>>
>> In its current form, the driver detects devices present on the bus and
>> registers them in the system. It allows registering BCMA drivers for
>> specified bus devices and provides them basic operations. The bus driver
>> itself includes two important bus managing drivers: ChipCommon core
>> driver and PCI(c) core driver. They are early used to allow correct
>> initialization.
>>
>> Currently code is limited to supporting buses on PCI(e) devices, however
>> the driver is designed to be used also on other hosts. The host
>> abstraction layer is implemented and already used for PCI(e).
>>
>> Support for PCI(e) hosts is working and seems to be stable (access to
>> 80211 core was tested successfully on a few devices). We can still
>> optimize it by using some fixed windows, but this can be done later
>> without affecting any external code. Windows are just ranges in MMIO
>> used for accessing cores on the bus.
>
> Hi Rafał,
>
> Just some minor feedback on coding style. I wanted to make a change in
> host_pci.c to avoid changing the PCI BAR window and noticed following:

Sorry?


> 1. indentation is all spaces.

You can find spaces only for aligning text in newline after breaking
more-than-80-chars lines.


> 2. initial indent is 7 spaces, and subsequent indents are 8 spaces.

$ grep "        " ./*c | wc -l
0


> 3. pointer assignment: ptr =&var;

$ grep "=&" ./*c | wc -l
0


> 4. output parameter: foo(bar,&yabar);

$ grep ",&" ./*c | wc -l
0

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/