linux-kernel - Re: [PATCH 2/3] printk: Add %ptc to safely print a task's comm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DD31397.1090603@jp.fujitsu.com>
Date:	Wed, 18 May 2011 09:32:23 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	john.stultz@...aro.org
CC:	linux-kernel@...r.kernel.org, tytso@....edu, rientjes@...gle.com,
	dave@...ux.vnet.ibm.com, akpm@...ux-foundation.org,
	linux-mm@...ck.org
Subject: Re: [PATCH 2/3] printk: Add %ptc to safely print a task's comm

(2011/05/17 6:19), John Stultz wrote:
> Accessing task->comm requires proper locking. However in the past
> access to current->comm could be done without locking. This
> is no longer the case, so all comm access needs to be done
> while holding the comm_lock.
> 
> In my attempt to clean up unprotected comm access, I've noticed
> most comm access is done for printk output. To simplify correct
> locking in these cases, I've introduced a new %ptc format,
> which will print the corresponding task's comm.
> 
> Example use:
> printk("%ptc: unaligned epc - sending SIGBUS.\n", current);
> 
> CC: Ted Ts'o<tytso@....edu>
> CC: KOSAKI Motohiro<kosaki.motohiro@...fujitsu.com>
> CC: David Rientjes<rientjes@...gle.com>
> CC: Dave Hansen<dave@...ux.vnet.ibm.com>
> CC: Andrew Morton<akpm@...ux-foundation.org>
> CC: linux-mm@...ck.org
> Signed-off-by: John Stultz<john.stultz@...aro.org>

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/