linux-kernel - Re: [PATCH/RESEND v10 2/7] usb: Configure endpoint according to gadget speed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110518100828.GJ11981@legolas.emea.dhcp.ti.com>
Date:	Wed, 18 May 2011 13:08:33 +0300
From:	Felipe Balbi <balbi@...com>
To:	Tatyana Brokhman <tlinder@...eaurora.org>
Cc:	greg@...ah.com, linux-usb@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, balbi@...com, ablay@...eaurora.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RESEND v10 2/7] usb: Configure endpoint according to
 gadget speed.

Hi,

On Tue, May 17, 2011 at 04:03:16PM +0300, Tatyana Brokhman wrote:
> Add config_ep_by_speed() to configure the endpoint according to the gadget
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 5c4c30c..7d1188a 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -132,6 +132,8 @@ struct usb_ep_ops {
>   *	value can sometimes be reduced (hardware allowing), according to
>   *      the endpoint descriptor used to configure the endpoint.
>   * @driver_data:for use by the gadget driver.
> + * @bEndpointAddress: used to identify the endpoint when finding

we only use CaMelCaSe when strictly necessary (like on the structures
defined by the specification) here you could call this field 'address'.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)