linux-kernel - Re: [PATCH] x86, ftrace: Fix compiler warning in ftrace.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1305725419.26849.16.camel@gandalf.stny.rr.com>
Date:	Wed, 18 May 2011 09:30:19 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	hpa@...or.com, Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] x86, ftrace: Fix compiler warning in ftrace.c

On Wed, 2011-05-18 at 11:02 +0600, Rakib Mullick wrote:
> 

>         
> Cause, __probe_kernel_write() currently takes void * as its parameter.
> That means all the users of __probe_kernel_write() currently passes
> void *. If we change __probe_kernel_write's parameter ( src) from void
> * to const void * , then all the callers also needs to do that. Isn't
> it?

No.

Look at __probe_kernel_write() itself. It calls
__copy_to_user_in_atomic() which takes const void *src, where we pass in
void *src. That __probe_kernel_write() having void *src is actually a
bug.

Make that a separate patch, or maybe I'll just do it.

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/