linux-kernel - Re: [PATCH] drm/i915/sdvo: Reorder i2c initialisation before ddc proxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yunei3wssyb.fsf@aiko.keithp.com>
Date:	Tue, 17 May 2011 18:22:52 -0700
From:	Keith Packard <keithp@...thp.com>
To:	Chris Wilson <chris@...is-wilson.co.uk>,
	Mihai Moldovan <ionic@...ic.de>
Cc:	linux-kernel@...r.kernel.org,
	Chris Wilson <chris@...is-wilson.co.uk>
Subject: Re: [PATCH] drm/i915/sdvo: Reorder i2c initialisation before ddc proxy

On Tue, 17 May 2011 14:03:50 +0100, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> The ddc proxy depends upon the underlying i2c bus being selected. Under
> certain configurations, the i2c-adapter functionality is queried during
> initialisation and so may trigger an OOPS during boot. Hence, we need to
> reorder the initialisation of the ddc proxy until after we hook up the i2c
> adapter for the SDVO device.

I'd love more explanation here about how this code ever worked -- what
are these 'certain configurations' of which you speak?

(on the surface, this patch seems sane, but I'd love to review with
specific knowledge about what configurations would have worked and which
would have triggered this bug).

-- 
keith.packard@...el.com

Content of type "application/pgp-signature" skipped