[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4DD30C9E.8010200@jp.fujitsu.com>
Date: Wed, 18 May 2011 09:02:38 +0900
From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To: wilsons@...rt.ca
CC: akpm@...ux-foundation.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, hughd@...gle.com,
rientjes@...gle.com, lee.schermerhorn@...com, adobriyan@...il.com,
cl@...ux-foundation.org
Subject: Re: [PATCH v2 7/9] mm: proc: move show_numa_map() to fs/proc/task_mmu.c
(2011/05/16 7:20), Stephen Wilson wrote:
> Moving show_numa_map() from mempolicy.c to task_mmu.c solves several
> issues.
>
> - Having the show() operation "miles away" from the corresponding
> seq_file iteration operations is a maintenance burden.
>
> - The need to export ad hoc info like struct proc_maps_private is
> eliminated.
>
> - The implementation of show_numa_map() can be improved in a simple
> manner by cooperating with the other seq_file operations (start,
> stop, etc) -- something that would be messy to do without this
> change.
>
> Signed-off-by: Stephen Wilson<wilsons@...rt.ca>
> Cc: KOSAKI Motohiro<kosaki.motohiro@...fujitsu.com>
> Cc: Hugh Dickins<hughd@...gle.com>
> Cc: David Rientjes<rientjes@...gle.com>
> Cc: Lee Schermerhorn<lee.schermerhorn@...com>
> Cc: Alexey Dobriyan<adobriyan@...il.com>
> Cc: Christoph Lameter<cl@...ux-foundation.org>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists