lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110518162338.GC23079@kroah.com>
Date:	Wed, 18 May 2011 09:23:38 -0700
From:	Greg KH <greg@...ah.com>
To:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Olaf Hartmann <o.hartmann@...ovital.com>
Subject: Re: [RFC/RFT PATCH] Staging: et131x: add suspend/resume support

On Wed, May 18, 2011 at 01:03:17PM -0300, Herton Ronaldo Krzesinski wrote:
> On Wed, May 18, 2011 at 08:24:28AM -0700, Greg KH wrote:
> > On Wed, May 18, 2011 at 10:17:47AM -0300, Herton Ronaldo Krzesinski wrote:
> > > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
> > 
> > I think we need a bit more comments here.
> > 
> > Like have you tested this to verify that it works?  Anything else?
> 
> An user complained about lack of suspend/resume support, so I did the
> patch, it's working accordingly to him from what I could get
> (unfortunately I can't test myself, don't have the hardware). I want
> others to test too, before this can be pushed (RFT on subject). The bug
> report I got: http://bugs.launchpad.net/bugs/766549
> But good luck in parsing that... I also want others with same
> hardware testing this, to confirm it is ok.

Ok, then please say so in the patch body itself next time.

I'll wait for you to get some testing, and then resend the patch, before
applying it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ