linux-kernel - Re: [RFC][PATCH] regulator: Fix _regulator_get_voltage if get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110518163205.GC16414@opensource.wolfsonmicro.com>
Date:	Wed, 18 May 2011 09:32:06 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [RFC][PATCH] regulator: Fix _regulator_get_voltage if
 get_voltage callback is NULL

On Wed, May 18, 2011 at 09:01:58PM +0800, Axel Lin wrote:

> @@ -1886,13 +1886,15 @@ static int _regulator_get_voltage(struct regulator_dev *rdev)
>  		if (sel < 0)
>  			return sel;
>  		ret = rdev->desc->ops->list_voltage(rdev, sel);
> +		goto out;
>  	}

Why are you adding this goto?  It's not going to change anything...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/