linux-kernel - Re: [PATCH] ALSA: sound, core, pcm_lib: fix xrun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hk4dn1con.wl%tiwai@suse.de>
Date:	Thu, 19 May 2011 07:28:40 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ben Gardiner <bengardiner@...ometrics.ca>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: sound, core, pcm_lib: fix xrun_log

At Wed, 18 May 2011 23:52:38 -0400,
Ben Gardiner wrote:
> 
> The xrun_log function was augmented with the in_interrupt parameter whereas the
> empty macro definition used when xrun logging is disabled was not.
> 
> Add a third parameter to the empty macro definition so as to not cause compiler
> errors when xrun logging (CONFIG_SND_PCM_XRUN_DEBUG) is disabled.
> 
> Signed-off-by: Ben Gardiner <bengardiner@...ometrics.ca>
> 
> ---
> This fixes the build error caused by ec08b14483de ("ALSA: sound, core, pcm_lib:
> xrun_log: log also in_interrupt") -- which was my patch. Sorry for the breakage.

Applied now.  Thanks.


Takashi

> 
> ---
>  sound/core/pcm_lib.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index c8c8091..abfeff16 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -266,7 +266,7 @@ static void xrun_log_show(struct snd_pcm_substream *substream)
>  #else /* ! CONFIG_SND_PCM_XRUN_DEBUG */
>  
>  #define hw_ptr_error(substream, fmt, args...) do { } while (0)
> -#define xrun_log(substream, pos)	do { } while (0)
> +#define xrun_log(substream, pos, in_interrupt)	do { } while (0)
>  #define xrun_log_show(substream)	do { } while (0)
>  
>  #endif
> -- 
> 1.7.4.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/