lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 May 2011 11:37:06 +0200 From: Ingo Molnar <mingo@...e.hu> To: Thomas Gleixner <tglx@...utronix.de> Cc: LKML <linux-kernel@...r.kernel.org>, LAK <linux-arm-kernel@...ts.infradead.org>, John Stultz <john.stultz@...aro.org> Subject: Re: [patch 5/7] clockevents: Provide interface to reconfigure an active clock event device * Thomas Gleixner <tglx@...utronix.de> wrote: > On Thu, 19 May 2011, Ingo Molnar wrote: > > * Thomas Gleixner <tglx@...utronix.de> wrote: > > > + */ > > > +int clockevents_reconfigure(struct clock_event_device *dev, u32 freq) > > > > This too could use a struct clockevents_params perhaps - and would only use > > params.freq for now but might be extended in the future. > > > > But i'm fine with this API as well: > > I agree for the config_register interface, but here we really just > want to update the frequency and not change any other parameter. ok, fair enough - in that case i'd suggest making that property explicitly visible in the API name, via something like: int clockevents_set_freq(struct clock_event_device *dev, u32 freq) That way it's obvious at first sight what this does: clockevents_set_freq(dev, 1000000); Versus: clockevents_reconfigure(dev, 1000000); Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists