linux-kernel - Re: BUG: NULL pointer deref in tty port / uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110519140735.GA1956@nowhere>
Date:	Thu, 19 May 2011 16:07:38 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Greg KH <gregkh@...e.de>, Alan Cox <alan@...ux.intel.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Kay Sievers <kay.sievers@...y.org>,
	Arnd Bergmann <arnd@...db.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: BUG: NULL pointer deref in tty port / uart

On Thu, May 19, 2011 at 03:58:29PM +0200, Jiri Olsa wrote:
> On Thu, May 19, 2011 at 05:51:20AM -0700, Greg KH wrote:
> > On Thu, May 19, 2011 at 01:19:01PM +0200, Jiri Olsa wrote:
> > > On Wed, May 18, 2011 at 12:42:12PM -0700, Greg KH wrote:
> > > > On Wed, May 18, 2011 at 03:50:33PM +0100, Alan Cox wrote:
> > > > > > I think it's the 
> > > > > > 
> > > > > > uart_update_termios in uart_dtr_rts (drivers/tty/serial/serial_core.c)
> > > > > > 
> > > > > > called path:
> > > > > > 
> > > > > > tty_port_block_til_ready
> > > > > > 	tty_port_raise_dtr_rts
> > > > > > 		uart_dtr_rts
> > > > > > 			uart_update_termios
> > > > > 
> > > > > Ah that would explain why I can't find and dup it - it isn't found in
> > > > > the current -next tree.
> > > > > 
> > > > > 
> > > > > c7d7abff40c27f82fe78b1091ab3fad69b2546f9 (and thereafter)
> > > > > 
> > > > > Jiri Slaby fixed it in sorting out uart_startup
> > > > > 
> > > > > I guess these should now get tagged for -stable.
> > > > 
> > > > So that would be the following patches in the linux-next tree:
> > > > 	c7d7abff40c27f82fe78b1091ab3fad69b2546f9 serial: core, move termios handling to uart_startup
> > > > 	303a7a1199c20f7c9452f024a6e17bf348b6b398 serial: core, do not set DTR/RTS twice on startup
> > > > 	6f5c24ad0f7619502199185a026a228174a27e68 serial: core, remove uart_update_termios
> > > > 
> > > > right?
> > > > 
> > > > Anything else need to be backported?
> > > > 
> > > > Frederic, can you test that these 3 patches solve the problem for you?
> > > > If you want, I can send them to you separately if you don't have a copy
> > > > of linux-next around anywhere.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > 
> > > I tried linux-next and cannot hit the issue anymore
> > 
> > That's great, but can you try .38 or .39 with those patches above and
> > verify that they solve the problem?
> 
> yes, this works for me as well

Thanks for your test!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/