linux-kernel - Re: linux-next: manual merge of the tip tree with the sparc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2011 17:35:06 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Daniel Hellstrom <daniel@...sler.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: linux-next: manual merge of the tip tree with the sparc tree

On Thu, 2011-05-19 at 15:37 +0200, Daniel Hellstrom wrote:


> diff --git a/arch/sparc/kernel/smp_32.c b/arch/sparc/kernel/smp_32.c
> index 41102c5..d5b3958 100644
> --- a/arch/sparc/kernel/smp_32.c
> +++ b/arch/sparc/kernel/smp_32.c
> @@ -156,11 +156,11 @@ void arch_send_call_function_ipi_mask(const struct 
> cpumask *mask)
> 
>  void smp_resched_interrupt(void)
>  {
> +       irq_enter();
> +       scheduler_ipi();
>         local_cpu_data().irq_resched_count++;
> -       /*
> -        * do nothing, since it all was about calling re-schedule
> -        * routine called by interrupt return code.
> -        */
> +       irq_exit();
> +       /* re-schedule routine called by interrupt return code. */
>  }

That doesn't look like an IPI, that looks like its calls the function on
the local cpu, which is completely pointless.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/