linux-kernel - Re: [PATCH] Enable Realtek ALC269 codec input layer beep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2011 18:18:19 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Madis Janson <madis@...er.ee>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Enable Realtek ALC269 codec input layer beep

At Thu, 19 May 2011 17:32:19 +0300 (EEST),
Madis Janson wrote:
> 
> 
> This fixes the input layer beep not working on some EeePC 1000 models by 
> adding the subsystem id into whitelist. Otherwise the corresponding ALSA 
> mixer is not enabled and stays muted, resulting in no console beep.

The change look good, but could you give your sign-off?
See Documentation/SubmittingPatches section 12 "Sign your work" for
details.

Also, at the next time, please try to send the patch to the
corresponding subsystem maintainers.  scripts/get_maintainer.pl is
your friend.


thanks,

Takashi

> diff -u linux-2.6.39/sound/pci/hda/patch_realtek.c lohe-2.6.39/sound/pci/hda/patch_realtek.c 
> --- linux-2.6.39/sound/pci/hda/patch_realtek.c	2011-05-19 07:06:34.000000000 +0300
> +++ lohe-2.6.39/sound/pci/hda/patch_realtek.c	2011-05-19 11:58:28.415669828 +0300
> @@ -5646,6 +5646,7 @@
>   	SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1),
>   	SND_PCI_QUIRK(0x1043, 0x83ce, "EeePC", 1),
>   	SND_PCI_QUIRK(0x1043, 0x831a, "EeePC", 1),
> +	SND_PCI_QUIRK(0x1043, 0x834a, "EeePC", 1),
>   	SND_PCI_QUIRK(0x8086, 0xd613, "Intel", 1),
>   	{}
>   };
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/