linux-kernel - Re: [RFC PATCH] perf: Split up buffer handling from core code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2011 19:20:39 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Borislav Petkov <bp@...en8.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [RFC PATCH] perf: Split up buffer handling from core code


* Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> On Thu, 2011-05-19 at 16:59 +0200, Frederic Weisbecker wrote:
> > I thought it would be nice to keep it inline for core use, as it's called
> > pretty often from the overflow path.
> 
> That's what I meant.
> 
> > A solution is to have a perf_output_copy_inline() in internal.h
> > and export it through perf_output_copy() in buffer.c 
> 
> If only "external inline" would work :-)
> 
> I'd call it __perf_output_copy() though, less typing.

Just __output_copy() please - if someone is looking at kernel/events/*.c then 
it's pretty clear that it's related to perf.

I.e. non-exposed symbols should lose their perf_ prefixes.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/