linux-kernel - Re: [PATCH] gpio: remove some legacy comments in build files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110519181827.GC5109@ponder.secretlab.ca>
Date:	Thu, 19 May 2011 12:18:27 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Lee Jones <lee.jones@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] gpio: remove some legacy comments in build files

On Thu, Apr 28, 2011 at 09:18:37AM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@...aro.org>
> 
> The build files for drivers/gpio has some wording and comments
> about the directory being reserved exclusively for GPIO expanders
> (according to the gpio.txt file these are on external busses) and
> this has been false for some time. We already have PL061 and
> Xilinx drivers which are in silicon and now I'm moving more
> silicon drivers here, so delete this and reword it a bit.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Applied, thanks.
g.

> ---
>  drivers/gpio/Kconfig  |    8 ++++----
>  drivers/gpio/Makefile |    6 +-----
>  2 files changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index c23401f..b7fac15 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1,5 +1,5 @@
>  #
> -# platform-neutral GPIO infrastructure and expanders
> +# GPIO infrastructure and drivers
>  #
>  
>  config ARCH_WANT_OPTIONAL_GPIOLIB
> @@ -31,7 +31,7 @@ menuconfig GPIOLIB
>  	help
>  	  This enables GPIO support through the generic GPIO library.
>  	  You only need to enable this, if you also want to enable
> -	  one or more of the GPIO expansion card drivers below.
> +	  one or more of the GPIO drivers below.
>  
>  	  If unsure, say N.
>  
> @@ -63,12 +63,12 @@ config GPIO_SYSFS
>  	  Kernel drivers may also request that a particular GPIO be
>  	  exported to userspace; this can be useful when debugging.
>  
> -# put expanders in the right section, in alphabetical order
> +# put drivers in the right section, in alphabetical order
>  
>  config GPIO_MAX730X
>  	tristate
>  
> -comment "Memory mapped GPIO expanders:"
> +comment "Memory mapped GPIO drivers:"
>  
>  config GPIO_BASIC_MMIO
>  	tristate "Basic memory-mapped GPIO controllers support"
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index e4851c5..cfbdef1 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -1,8 +1,4 @@
> -# generic gpio support: dedicated expander chips, etc
> -#
> -# NOTE: platform-specific GPIO drivers don't belong in the
> -# drivers/gpio directory; put them with other platform setup
> -# code, IRQ controllers, board init, etc.
> +# generic gpio support: platform drivers, dedicated expander chips, etc
>  
>  ccflags-$(CONFIG_DEBUG_GPIO)	+= -DDEBUG
>  
> -- 
> 1.7.3.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/