linux-kernel - Re: [57/71] block: rescan partitions on invalidated devices on -ENOMEDIA too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110519181814.GA17816@suse.de>
Date:	Thu, 19 May 2011 11:18:14 -0700
From:	Greg KH <gregkh@...e.de>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	stable-review@...nel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Jens Axboe <jaxboe@...ionio.com>
Subject: Re: [57/71] block: rescan partitions on invalidated devices on
 -ENOMEDIA too

On Thu, May 19, 2011 at 08:12:44PM +0200, Tejun Heo wrote:
> Hello, Greg.
> 
> On Thu, May 19, 2011 at 8:05 PM, Greg KH <gregkh@...e.de> wrote:
> >
> > 2.6.38-stable review patch.  If anyone has any objections, please let us know.
> >
> > ------------------
> >
> > From: Tejun Heo <tj@...nel.org>
> >
> > commit 02e352287a40bd456eb78df705bf888bc3161d3f upstream.
> >
> > __blkdev_get() doesn't rescan partitions if disk->fops->open() fails,
> > which leads to ghost partition devices lingering after medimum removal
> > is known to both the kernel and userland.  The behavior also creates a
> > subtle inconsistency where O_NONBLOCK open, which doesn't fail even if
> > there's no medium, clears the ghots partitions, which is exploited to
> > work around the problem from userland.
> >
> > Fix it by updating __blkdev_get() to issue partition rescan after
> > -ENOMEDIA too.
> >
> > This was reported in the following bz.
> >
> >  https://bugzilla.kernel.org/show_bug.cgi?id=13029
> >
> > Stable: 2.6.38
> >
> 
> Can you please hold this for a while?  It causes an extra warning
> message to be printed during device detection.  It isn't harmful but
> still.  I'll soon send a patch to resolve the issue and it would be
> better for them to go together.

Sure, I've dropped this one for now.  Let me know when I should add it
back to the next round of stable releases.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/