linux-kernel - RE: [PATCH] x86: Removing unnecessary check in detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2011 02:40:03 +0000
From:	"Rao, Nikhil" <nikhil.rao@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH]  x86: Removing unnecessary check in detect_ht

Hi Ingo,

Reposting as per your feedback.

Thanks,
Nikhil

---
This patch removes a check that causes incorrect scheduler domain
setup (SMP instead of SMT) and bootlog warning messages when cpuid
extensions for topology enumeration are not supported and the number
of processors reported to the OS is smaller than smp_num_siblings

Signed-off-by: Nikhil P Rao <nikhil.rao@...el.com>
Acked-by: Suresh Siddha <suresh.b.siddha@...el.com>
---
 arch/x86/kernel/cpu/common.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index e2ced007..6547084 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -458,13 +458,6 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
        if (smp_num_siblings <= 1)
                goto out;
 
-       if (smp_num_siblings > nr_cpu_ids) {
-               pr_warning("CPU: Unsupported number of siblings %d",
-                          smp_num_siblings);
-               smp_num_siblings = 1;
-               return;
-       }
-
        index_msb = get_count_order(smp_num_siblings);
        c->phys_proc_id = apic->phys_pkg_id(c->initial_apicid, index_msb);
 
-- 
1.7.4.2

> -----Original Message-----
> From: Ingo Molnar [mailto:mingo@...e.hu]
> Sent: Wednesday, May 18, 2011 2:24 PM
> To: Rao, Nikhil
> Cc: tglx@...utronix.de; mingo@...hat.com; hpa@...or.com;
> x86@...nel.org; Siddha, Suresh B; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] x86: Removing unnecessary check in detect_ht
> 
> 
> * Rao, Nikhil <nikhil.rao@...el.com> wrote:
> 
> > Nothing apart from what you mention - bootlog message and SMP instead
> of SMT.
> 
> Mind putting this information into the changelog and repost the patch?
> It's
> arguably the kind of practical information that most readers of
> changelogs are
> interested in.
> 
> Thanks,
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/