linux-kernel - Re: [RFC PATCH v3 2/6] of: Make of_find_node_by_path() traverse /aliases for relative paths.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110519185413.GE5109@ponder.secretlab.ca>
Date:	Thu, 19 May 2011 12:54:13 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	David Daney <ddaney@...iumnetworks.com>, linux-mips@...ux-mips.org,
	ralf@...ux-mips.org, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v3 2/6] of: Make of_find_node_by_path() traverse
 /aliases for relative paths.

On Fri, May 06, 2011 at 02:05:48PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 05-05-2011 21:02, David Daney wrote:
> 
> >Currently all paths passed to of_find_node_by_path() must begin with a
> >'/', indicating a full path to the desired node.
> 
> >Augment the look-up code so that if a path does *not* begin with '/',
> >the path is used as the name of an /aliases property.  The value of
> >this alias is then used as the full node path to be found.
> 
> >Signed-off-by: David Daney<ddaney@...iumnetworks.com>
> >---
> >  drivers/of/base.c |   41 ++++++++++++++++++++++++++++++++++++++++-
> >  1 files changed, 40 insertions(+), 1 deletions(-)
> 
> >diff --git a/drivers/of/base.c b/drivers/of/base.c
> >index 632ebae..1a0a83e 100644
> >--- a/drivers/of/base.c
> >+++ b/drivers/of/base.c
> [...]
> >@@ -348,14 +351,50 @@ EXPORT_SYMBOL(of_get_next_child);
> >  struct device_node *of_find_node_by_path(const char *path)
> >  {
> >  	struct device_node *np = allnodes;
> >+	struct device_node *aliases = NULL;
> >+	char *alias = NULL;
> >+	char *new_path = NULL;
> >
> >  	read_lock(&devtree_lock);
> >+
> >+	if (path[0] != '/') {
> >+		const char *ps;
> >+		aliases = of_find_node_by_path("/aliases");
> >+		if (!aliases)
> >+			goto out;
> >+
> >+		ps = strchr(path, '/');
> >+		if (ps) {
> >+			size_t len = ps - path;
> >+			alias = kmalloc(len + 1, GFP_KERNEL);
> 
>    How about error handling?

Yes, please add error handling and repost.

Thanks,
g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/