linux-kernel - Re: [PATCH] spi: Use void pointers for data in simple SPI I/O operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110519190034.GF5109@ponder.secretlab.ca>
Date:	Thu, 19 May 2011 13:00:34 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] spi: Use void pointers for data in simple SPI I/O
 operations

On Wed, May 11, 2011 at 12:09:30AM +0200, Mark Brown wrote:
> Currently the simple SPI I/O operations all take pointers to u8 * buffers
> to operate on. This creates needless type compatibility issues and the
> underlying spi_transfer structure uses void pointers anyway so convert the
> API over to take void pointers too.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Merged, thanks.

g.

> ---
>  drivers/spi/spi.c       |    4 ++--
>  include/linux/spi/spi.h |    8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index 82b9a42..2e13a14 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1047,8 +1047,8 @@ static u8	*buf;
>   * spi_{async,sync}() calls with dma-safe buffers.
>   */
>  int spi_write_then_read(struct spi_device *spi,
> -		const u8 *txbuf, unsigned n_tx,
> -		u8 *rxbuf, unsigned n_rx)
> +		const void *txbuf, unsigned n_tx,
> +		void *rxbuf, unsigned n_rx)
>  {
>  	static DEFINE_MUTEX(lock);
>  
> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
> index b4d7710..bb4f5fb 100644
> --- a/include/linux/spi/spi.h
> +++ b/include/linux/spi/spi.h
> @@ -581,7 +581,7 @@ extern int spi_bus_unlock(struct spi_master *master);
>   * Callable only from contexts that can sleep.
>   */
>  static inline int
> -spi_write(struct spi_device *spi, const u8 *buf, size_t len)
> +spi_write(struct spi_device *spi, const void *buf, size_t len)
>  {
>  	struct spi_transfer	t = {
>  			.tx_buf		= buf,
> @@ -605,7 +605,7 @@ spi_write(struct spi_device *spi, const u8 *buf, size_t len)
>   * Callable only from contexts that can sleep.
>   */
>  static inline int
> -spi_read(struct spi_device *spi, u8 *buf, size_t len)
> +spi_read(struct spi_device *spi, void *buf, size_t len)
>  {
>  	struct spi_transfer	t = {
>  			.rx_buf		= buf,
> @@ -620,8 +620,8 @@ spi_read(struct spi_device *spi, u8 *buf, size_t len)
>  
>  /* this copies txbuf and rxbuf data; for small transfers only! */
>  extern int spi_write_then_read(struct spi_device *spi,
> -		const u8 *txbuf, unsigned n_tx,
> -		u8 *rxbuf, unsigned n_rx);
> +		const void *txbuf, unsigned n_tx,
> +		void *rxbuf, unsigned n_rx);
>  
>  /**
>   * spi_w8r8 - SPI synchronous 8 bit write followed by 8 bit read
> -- 
> 1.7.5.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/