linux-kernel - Re: [PATCH 0/7] overlay filesystem v9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19925.27077.673335.609614@quad.stoffel.home>
Date:	Thu, 19 May 2011 15:04:37 -0400
From:	"John Stoffel" <john@...ffel.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Andy Whitcroft <apw@...onical.com>, viro@...IV.linux.org.uk,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, nbd@...nwrt.org, neilb@...e.de,
	hramrach@...trum.cz, jordipujolp@...il.com
Subject: Re: [PATCH 0/7] overlay filesystem v9

>>>>> "Miklos" == Miklos Szeredi <miklos@...redi.hu> writes:

Miklos> Andy Whitcroft <apw@...onical.com> writes:
>> On Tue, May 17, 2011 at 02:30:45PM +0200, Miklos Szeredi wrote:
>> 
>>> Here's an updated version of the overlay filesystem.
>>> 
>>> Git tree is here:
>>> 
>>> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs.v9
>> 
>> Ok I pulled this into the Ubuntu kernel and made an Ubuntu Live CD
>> for testing.  Overall it worked pretty well, no hangs, no crashes,
>> performance seemed reasonable.  We hit one issue with hard links which
>> fail to be possible on overlayfs mounts when the Yama LSM (out of tree)
>> is enabled.  This module applies more aggressive checks on hard-links
>> preventing links to files you cannot read.

Miklos> Great, thanks for testing.

>> The bug seems to be related to the way we handle user and group owners for
>> the overlayfs inodes, which we do not initialise (and they remain as 0,0).
>> While these ownerships are never exposed to userspace they are exposed
>> to the LSM layer, and the LSM module checks the wrong owner and fails
>> to allow the links.

Miklos> Hmm.

>> From what I can see it is completly reasonable to initialise the ownership
>> fields in the overlayfs inode from the underlying inode, or for new files
>> ones initialise it in the normal way based on the containing directory.
>> Now I am nothing like a filesystems expert but looking at what other
>> filesystems do I think the patch below is sufficient, but certainly it
>> needs some sanity checking.  At least it fixes all the issues I see
>> here.

Miklos> Forgot to attach the patch?

>> 
>> With this in place I have been able to boot a Natty release live CD
>> image, and upgrade it in place to the latest and greatest of everything.
>> Very nice.  Thanks for your work continuing work on overlayfs.  It is
>> starting to look good enough to merge.
>> 
>> Comments?

Miklos> I'd be happier if the LSM module were fixed not to peek inside the inode
Miklos> structure.  Some filesystems (notably network ones) do not guarantee i_*
Miklos> to be up-to-date, relying on these is not a good idea.

One question I have is why is a LiveCD even using the LSM modules?
It's not like it tells you anything you don't know... unless you're
planning on mounting some external disks and then reading in the LSM
checksums from somewhere to confirm.

Just curious.  

But I am happy to see the testing happening and overlayFS looks really
interesting too.  I can see it being used for a bunch of compute nodes
that all use the same hardware and software, and only need minor local
customization.

John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/