linux-kernel - Re: [PATCH 1/2] spi: spi_nuc900: Use spi_bitbang_stop instead of spi_unregister_master in nuc900_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110519193132.GQ5109@ponder.secretlab.ca>
Date:	Thu, 19 May 2011 13:31:32 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Wan ZongShun <mcuos.com@...il.com>,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH 1/2] spi: spi_nuc900: Use spi_bitbang_stop instead of
 spi_unregister_master in nuc900_spi_remove

On Sun, May 15, 2011 at 07:33:28AM +0800, Axel Lin wrote:
> Calling spi_bitbang_stop() will also destroy bitbang->workqueue,
> which is created by calling spi_bitbang_start() in nuc900_spi_probe().
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Applied, thanks.

g.

> ---
>  drivers/spi/spi_nuc900.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi_nuc900.c b/drivers/spi/spi_nuc900.c
> index d5be18b..3cd15f6 100644
> --- a/drivers/spi/spi_nuc900.c
> +++ b/drivers/spi/spi_nuc900.c
> @@ -463,7 +463,7 @@ static int __devexit nuc900_spi_remove(struct platform_device *dev)
>  
>  	platform_set_drvdata(dev, NULL);
>  
> -	spi_unregister_master(hw->master);
> +	spi_bitbang_stop(&hw->bitbang);
>  
>  	clk_disable(hw->clk);
>  	clk_put(hw->clk);
> -- 
> 1.7.1
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/