lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110520033949.GQ32466@dastard>
Date:	Fri, 20 May 2011 13:39:49 +1000
From:	Dave Chinner <david@...morbit.com>
To:	d.g.jansen@...glemail.com
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	tytso@....edu
Subject: Re: [rfc] Ignore Fsync Calls in Laptop_Mode

On Thu, May 19, 2011 at 03:34:46PM +0200, Dennis Jansen wrote:
> This is my first proper kernel code proposal so please bear with me!
> 
> =Summary for busy kernel hackers=
> Problem: laptop_mode wants to keep applications from waking the hard
> disks but fsync calls can "sneak through". (IMHO this is a bug.)
> 
> Proposed solution: Pretend the fsync was executed and successful.
> Insert two lines into the fsync and fdatasync calls in fs/sync.c:
> if (unlikely(laptop_mode))
>    return 0;

No, no, no, no, no, no, no, no, no, no.

There is _absolutely no justification_ for putting people's data at
risk like this.  If you want to do make fsync/fdatasync calls
no-ops, then go install libeatmydata on your systems. It's your
data, and you make the decision to risk it, not us.

And BTW, I just added your name to my "ignore fileystem/data
corruption bug reports from these people" list, because that's
exactly where you'll end up with if you follow this path.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ