linux-kernel - Re: [PATCH 5/7] overlay filesystem (inode.c bad error path)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wrhlah1e.fsf@tucsk.pomaz.szeredi.hu>
Date:	Fri, 20 May 2011 10:54:21 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Erez Zadok <ezk@....cs.sunysb.edu>
Cc:	"viro\@ZenIV.linux.org.uk" <viro@...IV.linux.org.uk>,
	"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm\@linux-foundation.org" <akpm@...ux-foundation.org>,
	"apw\@canonical.com" <apw@...onical.com>,
	"nbd\@openwrt.org" <nbd@...nwrt.org>,
	"neilb\@suse.de" <neilb@...e.de>,
	"hramrach\@centrum.cz" <hramrach@...trum.cz>,
	"jordipujolp\@gmail.com" <jordipujolp@...il.com>
Subject: Re: [PATCH 5/7] overlay filesystem (inode.c bad error path)

Erez Zadok <ezk@....cs.sunysb.edu> writes:

> I tried your overlayfs.v9 git repo w/ racer, using two separate ext3
> filesystems (one for lowerdir and another for upperdir).  I got the
> WARN_ON in ovl_permission to trigger within about 10 minutes of
> testing.  Looking at the code, I see a problem in returning w/o
> cleaning up an dput-ing the alias dentry.  Simple patch enclosed
> below.

Hmm, thanks.  The more interesting question is: why does that WARN_ON
trigger?  I'll look into it.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/