linux-kernel - Re: [PATCH v2] regulator: Fix _regulator_get_voltage if get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110520102302.GD22711@opensource.wolfsonmicro.com>
Date:	Fri, 20 May 2011 11:23:02 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [PATCH v2] regulator: Fix _regulator_get_voltage if get_voltage
 callback is NULL

On Fri, May 20, 2011 at 08:36:06AM +0800, Axel Lin wrote:

> -	return ret - rdev->constraints->uV_offset;
> +	return ret < 0 ? ret : ret - rdev->constraints->uV_offset;

Please don't use the ternery operator, I find it does nothing for
legibility.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/