linux-kernel - Re: [PATCH] x86: Removing unnecessary check in detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 May 2011 13:46:20 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Rao, Nikhil" <nikhil.rao@...el.com>
Cc:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]  x86: Removing unnecessary check in detect_ht


* Rao, Nikhil <nikhil.rao@...el.com> wrote:

> This patch removes a check that causes incorrect scheduler domain setup (SMP instead of SMT) and bootlog warning messages when cpuid extensions for topology enumeration are not supported and the number of processors reported to the OS is smaller than smp_num_siblings
> 
> Signed-off-by: Nikhil P Rao <nikhil.rao@...el.com>
> Acked-by: Suresh Siddha <suresh.b.siddha@...el.com>
> ---
>  arch/x86/kernel/cpu/common.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index cbc70a2..d2bcd54 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -477,13 +477,6 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
>         if (smp_num_siblings <= 1)
>                 goto out;
>  
> -       if (smp_num_siblings > nr_cpu_ids) {
> -               pr_warning("CPU: Unsupported number of siblings %d",
> -                          smp_num_siblings);
> -               smp_num_siblings = 1;
> -               return;
> -       }
> -

Your patch does not apply because it's whitespace damaged (all tabs got 
converted to spaces). Please see Documentation/email-clients.txt.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/